automod: rules engine framework #434
Conversation
automod/engine.go
Outdated
| } | ||
| collection := strings.SplitN(path, "/", 2)[0] | ||
|
|
||
| switch collection { |
There was a problem hiding this comment.
fyi: You can do a type switch in Go:
switch rec := rec.(type) {
case *appbsky.FeedPost:
// inside this case, rec is the correct type
}There was a problem hiding this comment.
yeah, I had it that way first, but need to verify collection/type mapping somehow (aka, type needs to be FeedPost and collection is "app.bsky.feed.post") and this felt more legible than switch on type and verify collection string.
|
|
||
| // base type for events. events are both containers for data about the event itself (similar to an HTTP request type); aggregate results and state (counters, mod actions) to be persisted after all rules are run; and act as an API for additional network reads and operations. | ||
| type Event struct { | ||
| Engine *Engine |
There was a problem hiding this comment.
it feels a bit odd to me that the event would carry the engine reference, seems like the 'persist' methods should just be on the engine itself and we should pass the event through that.
There was a problem hiding this comment.
yeah, agree this feels a bit weird.
the rules reach back to the engine other ways as well though: helpers on the event can fetch counters and things. it might be more golang-idiomatic to pass both the engine and the event to all rules.
part of this might be poor naming. "events" here are kind of more like echo.Context, maybe "EventContext" would be better.
might still be a bad design pattern.
There was a problem hiding this comment.
the more obvious/idiomatic thing would be to have the rules be methods on the engine, or methods on some context object in general. then you would access things like counters, logger, or other external resources through the parent struct. but i'm trying hard to make rules free-floating rules so they can be implemented in arbitrary packages and collected at configuration time.
bnewbold
force-pushed
the
bnewbold/automod
branch
from
9168140 to
cc9ed96
Compare
getRecord from Relay (BGS) wasn't working 🤷
| return nil | ||
| } | ||
|
|
||
| did, err := syntax.ParseDID(evt.Repo) |
There was a problem hiding this comment.
not now, but we should probably make lexgen use the syntax.DID type for fields that have format:did
There was a problem hiding this comment.
yup! I can't remember if I have tested yet, but the syntax.DID type implements the text marshaling interface, so this should Just Work
automodis a package to help write moderation automation "rules" to catch things like spam and flag accounts or content for human review (or potentially even auto-action).hepais a simple service which consumes from a BGS firehose and pushes events throughautomod.This is an early draft of the rules engine, some notes: